Add portal open/close logging with beacon and host IDs#2262
Merged
Conversation
- Log portal creation in mux_create.go with portal_id, beacon_id, host_id - Log portal close in api_create_portal.go sendPortalClose() with beacon/host info - Log portal close request in ClosePortal GraphQL mutation with beacon/host info - Log portal open in OpenPortal gRPC handler with beacon/host info - Eager-load host on beacon queries in CreatePortal for logging Agent-Logs-Url: https://github.com/spellshift/realm/sessions/9bdfc37c-7143-43af-a730-2854efdf1456 Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
Address code review feedback: add warning logs when beacon/host queries fail during portal open/close logging, instead of silently ignoring the errors. Agent-Logs-Url: https://github.com/spellshift/realm/sessions/9bdfc37c-7143-43af-a730-2854efdf1456 Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
KCarretto
April 17, 2026 22:27
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Portal lifecycle events (create, open, close) had no structured logging, making it difficult to trace portal activity back to specific beacons and hosts.
Changes
mux/mux_create.go— Eager-load host on beacon queries; log"portal created"withportal_id,beacon_id,host_idc2/api_create_portal.go— Log"portal closed"insendPortalClose()with beacon/host info queried from the portalgraphql/mutation.resolvers.go— Log"portal close requested"inClosePortalmutation with beacon/host infoportals/api_open_portal.go— Log"portal opened"inOpenPortalgRPC handler with beacon/host infoAll log calls use
slog.InfoContextwith structured key-value pairs. Beacon/host query failures emitslog.WarnContextand never block the operation.