addr_sync: update "stored_height" db field immediately on wallet-open#10414
Merged
ecdsa merged 1 commit intoJan 16, 2026
Merged
Conversation
Repro steps: - in qt gui, with network enabled, open wallet1 - open wizard, create wallet2 (restore from seed something that has mined history) - close both wallets, stop electrum - start electrum with "-o" offline flag, open wallet2 - observe all txs in history tab show up as "unconfirmed" The cause is that "stored_height" only gets updated ~on new blocks. So if you created a wallet and closed it soon, its db would not contain "stored_height."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro steps:
The cause is that "stored_height" only gets updated ~on new blocks. So if you created a wallet and closed it soon, its db would not contain "stored_height".