Skip to content

lnpeer: send channel update also for private channels, if we are forw…#10630

Merged
ecdsa merged 1 commit into
masterfrom
send_channel_update
May 6, 2026
Merged

lnpeer: send channel update also for private channels, if we are forw…#10630
ecdsa merged 1 commit into
masterfrom
send_channel_update

Conversation

@ecdsa
Copy link
Copy Markdown
Member

@ecdsa ecdsa commented May 6, 2026

…arding

@ecdsa ecdsa merged commit abc5e25 into master May 6, 2026
14 of 17 checks passed
@ecdsa ecdsa deleted the send_channel_update branch May 6, 2026 13:37
@f321x
Copy link
Copy Markdown
Member

f321x commented May 6, 2026

If the peer doesn't get the channel_update it will never get it in the future.
Maybe we should send it on reestablish as well?
Also the peer might prune old updates (though they shouldn't for their own channels), or our parameters have changed.

@SomberNight
Copy link
Copy Markdown
Member

If the peer doesn't get the channel_update it will never get it in the future.

Ahh, we still have the fallback code because lnd used to have the same bug. Let's try not to repeat that.

Maybe we should send it on reestablish as well?

Yeah, I agree. Let's just send it near the end of reestablish_channel().

f321x added a commit to f321x/electrum-fork that referenced this pull request May 8, 2026
If we have forwarding enabled, send a channel_update message to the
peer after a channel_reestablish.
The peer needs to know our channel constraints to receive a payment
(for r_tags or blinded path) and sending it just once on mark_open
might not be enough as the peer could miss it, lose it or it might
get out of date if we'd change our forwarding fees.
See spesmilo#10630 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants