lnonion/trampoline: stop double counting HMAC size#10668
Merged
Conversation
`OnionHopsDataSingle.to_bytes()` already accounts for the onions hmac internally, it seems incorrect that we were additionally adding `PER_HOP_HMAC_SIZE` to the payload size of the payload returned by `.to_bytes()`.
SomberNight
approved these changes
May 26, 2026
Member
SomberNight
left a comment
There was a problem hiding this comment.
Right.. Yes, that seems to have been a logic bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OnionHopsDataSingle.to_bytes()already accounts for the onions hmac internally,it seems incorrect that we were additionally adding
PER_HOP_HMAC_SIZEto the payloadsize of the payload returned by
.to_bytes().electrum/electrum/lnonion.py
Lines 76 to 92 in 8e96fef