plugin: nwc: regularly rebroadcast info event#10689
Merged
Merged
Conversation
It seemed weird to pass the taskgroup of the plugin into the NWCServer, this looks a bit cleaner. It also allows to get multiple tasks of the NWCServer cancelled by cancelling the NWCServers taskgroup.
I noticed with my long running NWC deamon that after a couple days some clients relying on the info event being available stopped working. Alby e.g. shows "Error: no info event (kind 13194) returned from relay". After restarting the daemon it works again for some days. It seems that relays drop the info events after some days, even though they are not ephemeral and don't have an expiry tag. So rebroadcasting them once a day should make the server more reliable.
f321x
force-pushed
the
rebroadcast_info_event
branch
from
9c839a4 to
60e3881
Compare
Member
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed with my long running NWC daemon that after a
couple days some clients relying on the info event being
available stopped working. Alby e.g. shows
"Error: no info event (kind 13194) returned from relay".
After restarting the daemon it works again for some days.
It seems that relays drop the info events after some days,
even though they are not ephemeral and don't have an expiry tag.
So rebroadcasting them once a day should make the NWC server more
reliable.