Add ToStringMapStruct()#58
Open
albttx wants to merge 2 commits intospf13:masterfrom
Open
Conversation
|
|
bep
reviewed
Dec 3, 2018
| expect map[string]struct{} | ||
| iserr bool | ||
| }{ | ||
| {map[string]interface{}{"v1": true, "v2": false}, map[string]struct{}{"v1": struct{}{}, "v2": struct{}{}}, false}, |
Collaborator
There was a problem hiding this comment.
I understand that the casting that this library does implies some conversion, but how can both true and false be the same as struct{}{}?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the possibility to cast a slice into a hashset (
map[string]struct{}).The
struct{}element worth 0 byte, and it's really useful for checking if a key is present. here an article about the empty struct.This pull request is link with spf13/viper#437 to add this feature for parsing slice.