Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trailing whitespace in the powershell completion script #1342

Merged
merged 1 commit into from Feb 14, 2021

Conversation

@Luap99
Copy link
Contributor

@Luap99 Luap99 commented Feb 10, 2021

No description provided.

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
@marckhouzam
Copy link
Contributor

@marckhouzam marckhouzam commented Feb 10, 2021

Just to confirm, this is just esthetic, there is no actual bug?

@Luap99
Copy link
Contributor Author

@Luap99 Luap99 commented Feb 10, 2021

Just to confirm, this is just esthetic, there is no actual bug?

Yes I should have mention that.

I want to commit the generated files but the podman CI is failing because of the trailing whitespace

@Luap99
Copy link
Contributor Author

@Luap99 Luap99 commented Feb 10, 2021

@jpmcb This should be an easy one.

Copy link
Contributor

@marckhouzam marckhouzam left a comment

I did some quick testing with helm and this looks safe.

@jpmcb
jpmcb approved these changes Feb 14, 2021
Copy link
Collaborator

@jpmcb jpmcb left a comment

Good catch. Removing the trailing whitespace for CI and git compatibility makes sense.

I currently don't have a great way to test out Windows or powershell things. So thanks for testing this out Marc! I really need to find a way to test these windows changes out. Maybe I'll buy a cheap windows PC or side-load onto my Mac. What do you do to test powershell changes @marckhouzam?

Anyways - merged! 🚀

@jpmcb jpmcb merged commit ded486a into spf13:master Feb 14, 2021
7 checks passed
7 checks passed
@github-actions
ubuntu | 1.14.x
Details
@github-actions
ubuntu | 1.15.x
Details
@github-actions
macOS | 1.14.x
Details
@github-actions
macOS | 1.15.x
Details
@github-actions
MINGW64
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@Luap99 Luap99 deleted the Luap99:powershell-trailing-space branch Feb 14, 2021
@Luap99
Copy link
Contributor Author

@Luap99 Luap99 commented Feb 14, 2021

@jpmcb You can install powershell on linux. Maybe I can create a simple dockerfile to test it in a container.
https://docs.microsoft.com/en-gb/powershell/scripting/install/installing-powershell-core-on-linux?view=powershell-7.1

@marckhouzam
Copy link
Contributor

@marckhouzam marckhouzam commented Feb 14, 2021

@jpmcb I've installed PowerShell directly on my Mac. There is a brew installation for it: https://docs.microsoft.com/en-us/powershell/scripting/install/installing-powershell-core-on-macos?view=powershell-7.1

@jpmcb
Copy link
Collaborator

@jpmcb jpmcb commented Feb 14, 2021

Good to know! I figured that powershell was a windows only thing 😅 I'll make sure to give that a try in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants