fix(cleanpath): use forward slash as path separator on all platforms (#87)#89
Open
SAY-5 wants to merge 1 commit intospf13:mainfrom
Open
fix(cleanpath): use forward slash as path separator on all platforms (#87)#89SAY-5 wants to merge 1 commit intospf13:mainfrom
SAY-5 wants to merge 1 commit intospf13:mainfrom
Conversation
CleanPath split and joined on filepath.Separator which is '\\' on
Windows. Since '\\' (and '/') are both stripped by
CharacterFilterRegex, splitting on '\\' on Windows collapsed any
forward-slash path into one component and lost every '/' separator
— e.g. CleanPath("foo/bar/baz") returned "foobarbaz" on Windows
while returning "foo/bar/baz" on Unix. That also broke Test_paths
on Windows.
Use a literal '/' as the path separator. Forward slash is the
portable separator already used throughout the test fixtures, and
back slash is already removed by the invalid-character filter, so
the behaviour is now identical across platforms.
Fixes spf13#87
Signed-off-by: SAY-5 <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CleanPathsplit and joined onfilepath.Separator, which is\on Windows. Since both\and/are stripped byCharacterFilterRegex, on Windows thestrings.Splitcall never matched, the entire input became a single component, and every/was deleted byremoveInvalidCharacters. On Unix everything worked fine — the bug was purely Windows.This made
Test_pathsfail with e.g.:Fix: split and join on a literal
/on every platform. Forward slash is the portable separator the tests already use, and back slash is already removed by the invalid-character filter, so the cleaning behaviour is unchanged on Unix and matches the documented expectations on Windows.Fixes #87
Test plan
go build ./...go test ./...(Unix) passesGOOS=windows go test -c ./...compiles cleanly