fix: reject single-dash long flag names#474
Closed
leno23 wants to merge 1 commit into
Closed
Conversation
|
|
When an argument matches a registered long flag name but uses one leading dash (e.g. -name), return a clear error instead of parsing it as shorthand plus a value suffix. Go test flags (-test.*) are exempt. Fixes spf13/cobra#2358
leno23
force-pushed
the
fix/reject-single-dash-long-flag-2358
branch
from
52db632 to
67350f5
Compare
Collaborator
|
This is the same change as #473, rejected for the same reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-nameand-name=valueare no longer parsed as shorthand-nplus a value suffix whennameis a registered long flag. Users get an explicit error to use--nameinstead.Go test flags (
-test.*) continue to work via the existingtest.prefix exemption.Tests
TestParseRejectsSingleDashLongFlagFixes spf13/cobra#2358
Made with Cursor