fix: honor custom IsBoolFlag compatibility#487
Open
happysnaker wants to merge 1 commit into
Open
Conversation
Author
|
Maintainer context for review:
|
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Valueimplementations withIsBoolFlag() == trueas no-opt bool flags consistentlyNoOptDefVal="true"for those custom bool-like valuesProblem
pflagalready exposesIsBoolFlag()for bool-like values, but several code paths still special-case only the built-inbooltype. That leaves custom bool-like values in an inconsistent state:--flag/-fcan fail unless callers manually setNoOptDefValChanges
IsBoolFlag()NoOptDefValinAddFlag()for custom bool-like valuesdefaultIsZeroValue(),UnquoteUsage(), andFlagUsagesWrapped()Fixes #281
Fixes #360