-
Notifications
You must be signed in to change notification settings - Fork 23
Change build generation logic to use Github Actions instead of Travis #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauloborba
approved these changes
Mar 9, 2021
Member
|
@rafaelmotaalves não tem impacto no README? |
barbosamaatheus
approved these changes
Mar 10, 2021
barbosamaatheus
approved these changes
Mar 10, 2021
Collaborator
Author
Tem algumas menções diretas ao Travis. Vou tentar deixar mais geral @pauloborba |
galilasmb
approved these changes
Mar 13, 2021
leusonmario
approved these changes
Mar 17, 2021
pauloborba
approved these changes
Mar 17, 2021
03c6d4c to
54175ee
Compare
54175ee to
4e46189
Compare
Collaborator
Author
|
@pauloborba fiz os ajustes de documentação |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts all CI platform-specific logic to the classes that implement the CIPlatform interface, that way we can easily change the platform we are using for generating builds, the currently supported platforms are Travis and Github Actions, and currently set being Github Actions. Also, some adaptions were made to the code to support these architectural changes.
@leusonmario because this logic was also used for your implementation, I had to make some changes to that as well, could you check if it is working properly now using Github Actions?