Add Chord length Test #100
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry, I'm still a bit lost on this. How would I actually write a unit test using this? Is there any way to add chord length tests to our testing .m file? |
|
@cgyurgyik our function could output [rVoxels, thetaVoxels, phiVoxels, traversal time] and we could then have a verification on this value where the expected value is calculated externally in a different function. |
|
@nukenukenukelol @cgyurgyik after you review the PR #103 can @nukenukenukelol migrate the above into the new code? |
Yes will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add chord length test to the spherical case. The logic is similar to the polar one. We first find the expected chord length via the entry and exit time calculation. Then, we use an accumulator to keep track of total time we spend on traversal.