Multiple updates; test passer #103
Merged
+232
−159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pointArray update from main traversal.
This was
linked to
issues
Apr 17, 2020
Closed
cgyurgyik
reviewed
Apr 17, 2020
cgyurgyik
reviewed
Apr 17, 2020
| pert_x = sphere_center(1) + ray_direction(1) * pert_t; | ||
| pert_z = sphere_center(3) + ray_direction(3) * pert_t; | ||
| a = sphere_center(1) - pert_x; | ||
| b = sphere_center(2) - pert_z; |
There was a problem hiding this comment.
Should this be: b = sphere_center(3) - pert_z;
|
IMO, the use of versus There's also a lot of boolean reduction that can occur (I've tackled some of this in the cpp code already), but since this isn't the production code, not a big deal. Other than that, and the comment above, LGTM. |
cgyurgyik
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple updates to the traversal phase, the azimuthal/angular hits, and the test cases.
Traversal phase: remove costly array updates in traversal main.
Azimuthal/angular hit: include collinear cases in conditionals, update time comparisons to use function strictly less than.
Test cases: Update test cases based on (a) traversal choices for ambiguities such as ray collinear with boundaries and (b) corrections made by checking 3D vis. in GeoGebra.