Resolve a few mypy issues in tests #12912
Merged
+24
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of these issues allow us yet to remove particular overrides, but these changes, I hope, are small enough that they make sense to merge, as progress towards the larger goal of removing overrides.
AA-Turner
approved these changes
Sep 23, 2024
Member
|
ping on green for merge |
AA-Turner
changed the title
Contributor
Author
|
Ping, and thank you @AA-Turner I should have watched CI. |
AA-Turner
reviewed
Sep 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of these issues allow us yet to remove particular overrides, but these changes, I hope, are small enough that they make sense to merge, as progress towards the larger goal of removing overrides.