[reverted] feat: Support custom parameters in extra context#15
Merged
Conversation
ExtraContext.generate() now accepts *args, **kwargs, and load_extra()
passes them through from the template. This enables parameterized
extra contexts like load_extra('all_docs', count=3).
Changes:
- ExtraContext.generate signature: (self, req, *args, **kwargs)
- extra_context_loader forwards *args, **kwargs from the template
- Built-in contexts updated to accept the new signature
- New test root test-extra-context-params with all_docs example
- Docs updated with working examples
Co-authored-by: deepseek-ai <service@deepseek.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExtraContext.generate() now accepts
*args, **kwargs, andload_extra()passes them through from the template. This enables parameterized extra contexts likeload_extra('all_docs', count=3).Changes
ExtraContext.generatesignature:(self, req, *args, **kwargs)extra_context_loaderforwards*args, **kwargsfrom the templatetest-extra-context-paramswithall_docsexampleUsage