Skip to content

fix: Correct IMAP ssl_mode default from tls to auto#1529

Merged
lukekim merged 2 commits into
trunkfrom
fix/imap-ssl-mode-default
Apr 21, 2026
Merged

fix: Correct IMAP ssl_mode default from tls to auto#1529
lukekim merged 2 commits into
trunkfrom
fix/imap-ssl-mode-default

Conversation

@claudespice
Copy link
Copy Markdown
Collaborator

Summary

  • The IMAP connector docs stated the default imap_ssl_mode is tls, but the code uses auto as the default (.default("auto") in the ParameterSpec)
  • This has been wrong since at least v1.5.0

Changes

  • Updated the imap_ssl_mode default from tls to auto across all 8 doc versions (vNext + 1.5.x through 1.11.x)

Reference

Verified against spiceai/spiceai at trunkcrates/data-connectors/connector-imap/src/lib.rs (line 56: .default("auto"))

Also verified at tag v1.5.0 — same default value.

@claudespice claudespice added the bug Something isn't working label Apr 19, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 19, 2026

✅ Pull with Spice Passed

Passing checks:

  • ✅ Title meets minimum length requirement (10 characters)
  • ✅ Has at least one of the required labels: area/blog, area/docs, area/cookbook, dependencies
  • ✅ No banned labels detected
  • ✅ Has at least one assignee: lukekim

@github-actions
Copy link
Copy Markdown

🚀 deployed to https://5d5d1194.spiceai-org-website.pages.dev

The documentation incorrectly states the IMAP connector's `imap_ssl_mode`
parameter defaults to `tls`. The actual default in the code is `auto`
(ParameterSpec in connector-imap/src/lib.rs).

Fixed across all versioned docs (1.5.x through 1.11.x) and vNext.
@github-actions
Copy link
Copy Markdown

🚀 deployed to https://e074135b.spiceai-org-website.pages.dev

@lukekim lukekim self-assigned this Apr 20, 2026
@github-actions
Copy link
Copy Markdown

🚀 deployed to https://cc20eddd.spiceai-org-website.pages.dev

@lukekim lukekim merged commit 673da3b into trunk Apr 21, 2026
6 of 7 checks passed
@lukekim lukekim deleted the fix/imap-ssl-mode-default branch April 21, 2026 18:29
Copilot AI pushed a commit that referenced this pull request Apr 21, 2026
Co-authored-by: lukekim <80174+lukekim@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants