fix: Correct IMAP ssl_mode default from tls to auto#1529
Merged
Conversation
✅ Pull with Spice PassedPassing checks:
|
|
🚀 deployed to https://5d5d1194.spiceai-org-website.pages.dev |
The documentation incorrectly states the IMAP connector's `imap_ssl_mode` parameter defaults to `tls`. The actual default in the code is `auto` (ParameterSpec in connector-imap/src/lib.rs). Fixed across all versioned docs (1.5.x through 1.11.x) and vNext.
577c5dd to
b0bee4b
Compare
|
🚀 deployed to https://e074135b.spiceai-org-website.pages.dev |
lukekim
approved these changes
Apr 20, 2026
|
🚀 deployed to https://cc20eddd.spiceai-org-website.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
imap_ssl_modeistls, but the code usesautoas the default (.default("auto")in the ParameterSpec)Changes
imap_ssl_modedefault fromtlstoautoacross all 8 doc versions (vNext + 1.5.x through 1.11.x)Reference
Verified against
spiceai/spiceaiattrunk—crates/data-connectors/connector-imap/src/lib.rs(line 56:.default("auto"))Also verified at tag
v1.5.0— same default value.