Skip to content

fix: Correct MySQL deployment guide pool params, SSL modes, and metric name#1534

Merged
lukekim merged 2 commits into
trunkfrom
fix/mysql-deployment-docs
Apr 20, 2026
Merged

fix: Correct MySQL deployment guide pool params, SSL modes, and metric name#1534
lukekim merged 2 commits into
trunkfrom
fix/mysql-deployment-docs

Conversation

@claudespice
Copy link
Copy Markdown
Collaborator

Summary

  • Connection pool parameter names were wrong: connection_pool_min_idle/connection_pool_sizemysql_pool_min/mysql_pool_max (defined as ParameterSpec::component("pool_min") and component("pool_max") in connector-mysql)
  • verify_ca SSL mode was documented but is not implemented — the connector only supports disabled, preferred, and required
  • Metric name was wrong: discarded_excess_idle_connectiondiscarded_superfluous_connection

Changes

  • Fixed pool parameter names and updated all references throughout the deployment guide
  • Removed verify_ca from the SSL mode table and all references in troubleshooting/limitations
  • Corrected the metric name in the metrics table

Reference

Verified against spiceai/spiceai at trunk:

- Fix connection pool parameter names: `connection_pool_min_idle` →
  `mysql_pool_min`, `connection_pool_size` → `mysql_pool_max`
- Remove unsupported `verify_ca` SSL mode (only `disabled`, `preferred`,
  and `required` are supported by the connector)
- Fix metric name: `discarded_excess_idle_connection` →
  `discarded_superfluous_connection`
@claudespice claudespice added the bug Something isn't working label Apr 20, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2026

✅ Pull with Spice Passed

Passing checks:

  • ✅ Title meets minimum length requirement (10 characters)
  • ✅ Has at least one of the required labels: area/blog, area/docs, area/cookbook, dependencies
  • ✅ No banned labels detected
  • ✅ Has at least one assignee: lukekim

@github-actions
Copy link
Copy Markdown

🚀 deployed to https://657d05cc.spiceai-org-website.pages.dev

@lukekim lukekim self-assigned this Apr 20, 2026
@github-actions
Copy link
Copy Markdown

🚀 deployed to https://e7fec991.spiceai-org-website.pages.dev

@lukekim lukekim merged commit 047779e into trunk Apr 20, 2026
6 checks passed
@lukekim lukekim deleted the fix/mysql-deployment-docs branch April 20, 2026 17:25
Copilot AI pushed a commit that referenced this pull request Apr 21, 2026
Co-authored-by: lukekim <80174+lukekim@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants