fix: Correct MySQL deployment guide pool params, SSL modes, and metric name#1534
Merged
Conversation
- Fix connection pool parameter names: `connection_pool_min_idle` → `mysql_pool_min`, `connection_pool_size` → `mysql_pool_max` - Remove unsupported `verify_ca` SSL mode (only `disabled`, `preferred`, and `required` are supported by the connector) - Fix metric name: `discarded_excess_idle_connection` → `discarded_superfluous_connection`
✅ Pull with Spice PassedPassing checks:
|
|
🚀 deployed to https://657d05cc.spiceai-org-website.pages.dev |
lukekim
approved these changes
Apr 20, 2026
|
🚀 deployed to https://e7fec991.spiceai-org-website.pages.dev |
Copilot AI
pushed a commit
that referenced
this pull request
Apr 21, 2026
Co-authored-by: lukekim <80174+lukekim@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connection_pool_min_idle/connection_pool_size→mysql_pool_min/mysql_pool_max(defined asParameterSpec::component("pool_min")andcomponent("pool_max")in connector-mysql)verify_caSSL mode was documented but is not implemented — the connector only supportsdisabled,preferred, andrequireddiscarded_excess_idle_connection→discarded_superfluous_connectionChanges
verify_cafrom the SSL mode table and all references in troubleshooting/limitationsReference
Verified against spiceai/spiceai at trunk: