Skip to content

fix: Correct MySQL required SSL mode — it verifies certificates#1707

Merged
lukekim merged 1 commit into
trunkfrom
fix/docs-mysql-sslmode-description
May 10, 2026
Merged

fix: Correct MySQL required SSL mode — it verifies certificates#1707
lukekim merged 1 commit into
trunkfrom
fix/docs-mysql-sslmode-description

Conversation

@claudespice
Copy link
Copy Markdown
Collaborator

Summary

  • The mysql_sslmode: required mode uses SslOpts::default() which sets accept_invalid_certs=false and skip_domain_validation=false, meaning it verifies the server certificate against system root CAs and validates the domain name
  • The docs incorrectly stated "do not verify the server certificate" and "does not validate the server's identity"
  • The Known Limitations section incorrectly stated certificate verification is not supported — the required mode provides equivalent behavior to verify_identity

Changes

  • Corrected required mode description to reflect actual certificate verification behavior
  • Updated Known Limitations to accurately describe the available SSL modes

Reference

Verified against datafusion-table-providers mysqlpool.rs get_ssl_opts() function — required mode returns SslOpts::default() (verifies certs), while preferred mode explicitly sets with_danger_accept_invalid_certs(true).

Files updated: 1

The mysql_sslmode: required mode uses SslOpts::default() which sets
accept_invalid_certs=false and skip_domain_validation=false, meaning
it verifies the server certificate against system root CAs and validates
the domain name. The docs incorrectly stated it does not verify.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 10, 2026

✅ Pull with Spice Passed

Passing checks:

  • ✅ Title meets minimum length requirement (10 characters)
  • ✅ Has at least one of the required labels: area/blog, area/docs, area/cookbook, dependencies
  • ✅ No banned labels detected
  • ✅ Has at least one assignee: claudespice

@github-actions
Copy link
Copy Markdown

🚀 deployed to https://ea90ed87.spiceai-org-website.pages.dev

@lukekim lukekim merged commit 9da2dc4 into trunk May 10, 2026
9 of 13 checks passed
@lukekim lukekim deleted the fix/docs-mysql-sslmode-description branch May 10, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants