fix: Correct MySQL required SSL mode — it verifies certificates#1707
Merged
Conversation
The mysql_sslmode: required mode uses SslOpts::default() which sets accept_invalid_certs=false and skip_domain_validation=false, meaning it verifies the server certificate against system root CAs and validates the domain name. The docs incorrectly stated it does not verify.
✅ Pull with Spice PassedPassing checks:
|
|
🚀 deployed to https://ea90ed87.spiceai-org-website.pages.dev |
lukekim
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mysql_sslmode: requiredmode usesSslOpts::default()which setsaccept_invalid_certs=falseandskip_domain_validation=false, meaning it verifies the server certificate against system root CAs and validates the domain namerequiredmode provides equivalent behavior toverify_identityChanges
requiredmode description to reflect actual certificate verification behaviorReference
Verified against
datafusion-table-providersmysqlpool.rsget_ssl_opts()function —requiredmode returnsSslOpts::default()(verifies certs), whilepreferredmode explicitly setswith_danger_accept_invalid_certs(true).Files updated: 1