fix: Remove non-functional rate control params from GitHub connector docs#1713
Merged
Conversation
…docs The GitHub connector does not consume requests_per_second_limit, requests_per_minute_limit, rate_control_jitter_min, or rate_control_jitter_max — they are not in the connector's ParameterSpec array. The GitHub connector uses its own rate limiter based on GitHub API X-RateLimit-* response headers, not the generic HTTP rate control mechanism. Users setting these params have them silently ignored. Keep max_concurrent_requests which IS wired into the connector.
✅ Pull with Spice PassedPassing checks:
|
🔍 Pull with Spice FailedPassing checks:
Failed checks:
Please address these issues and update your pull request. |
|
🚀 deployed to https://3c12b2e3.spiceai-org-website.pages.dev |
lukekim
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub connector docs list 4 HTTP rate control parameters that are not in the connector PARAMETERS array and are silently ignored. The GitHub connector uses its own rate limiter based on X-RateLimit-* headers, not the generic HTTP rate control mechanism. Removed the 4 non-functional parameters while keeping max_concurrent_requests which IS wired in. Verified against spiceai/spiceai trunk.