Add missing github token param#980
Merged
Merged
Conversation
Without `gh_token`, it hits the rate limit right away.
lukekim
approved these changes
May 7, 2025
Contributor
|
Thank you! |
Contributor
Author
|
Hello, is there anything else I need to do for it to be merged? |
peasee
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
Without
GITHUB_TOKEN, it hits the rate limit right away:🤔 Concerns
If a new user reading this doesn't have their
GITHUB_TOKENin their.env, it increases the friction to trying out this core feature of spice.ai. An alternative to this example is to use a csv file hosted on github: