Skip to content

dependencies: Cherry-pick updates for DuckDB 1.4.3#12

Merged
peasee merged 3 commits into
spiceai-1.4.3from
peasee/20260118-duckdb-update
Jan 18, 2026
Merged

dependencies: Cherry-pick updates for DuckDB 1.4.3#12
peasee merged 3 commits into
spiceai-1.4.3from
peasee/20260118-duckdb-update

Conversation

@peasee
Copy link
Copy Markdown

@peasee peasee commented Jan 17, 2026

mach-kernel and others added 3 commits January 18, 2026 09:12
ART Index: Support compound key scans

Squashed commit of the following:

commit fec3602
Author: David Stancu <david@spice.ai>
Date:   Mon Nov 3 14:26:06 2025 -0500

    tryscanindex: fix direct match lookup, range check vec access

commit 2714c3d
Author: David Stancu <david@spice.ai>
Date:   Mon Nov 3 13:55:13 2025 -0500

    tryscanindex: do column matching first, to use possibly rebound matches in both sanity check and index expr rebinding
    add test for this scenario

commit 36ffa5b
Author: David Stancu <david@spice.ai>
Date:   Mon Nov 3 12:30:28 2025 -0500

    tryscanindex sanity check: indexed_columns / art column ids may not need remapping if the scan is not a view scan

commit 525f9c7
Author: David Stancu <david@spice.ai>
Date:   Thu Oct 30 10:42:17 2025 -0400

    do not do index scan if there are other non index filters in the predicate (fix shutdown_create_index.test)

commit b0a6e2d
Author: David Stancu <david@spice.ai>
Date:   Thu Oct 30 10:04:54 2025 -0400

    add test, bail out for eg composite query with IN () list

commit a22a430
Author: David Stancu <david@spice.ai>
Date:   Wed Oct 29 16:37:30 2025 -0400

    simplify filter expression storage index bindings (just reuse the ones we made earlier), fix single-ref-per-expr predicate to correctly walk expr tree and yank refs (allowing nesting in fns, etc)

commit 9c8c1ed
Author: David Stancu <david@spice.ai>
Date:   Wed Oct 29 15:11:23 2025 -0400

    copy index expressions before rewriting column refs

commit aff2c98
Author: David Stancu <david@spice.ai>
Date:   Wed Oct 29 14:36:33 2025 -0400

    table scan:

    rebind projected columns in ALL index exprs
    do not bail out early if more than one index expr
    hook up composite key scan

commit bfc6f02
Author: David Stancu <david@spice.ai>
Date:   Wed Oct 29 14:35:09 2025 -0400

    make specialized compound key scan state for eq compares, specialized scan using ARTKey::Concat
* make specialized compound key scan state for eq compares, specialized scan using ARTKey::Concat

* table scan:

rebind projected columns in ALL index exprs
do not bail out early if more than one index expr
hook up composite key scan

* copy index expressions before rewriting column refs

* simplify filter expression storage index bindings (just reuse the ones we made earlier), fix single-ref-per-expr predicate to correctly walk expr tree and yank refs (allowing nesting in fns, etc)

* add test, bail out for eg composite query with IN () list

* do not do index scan if there are other non index filters in the predicate (fix shutdown_create_index.test)

* tryscanindex sanity check: indexed_columns / art column ids may not need remapping if the scan is not a view scan

* tryscanindex: do column matching first, to use possibly rebound matches in both sanity check and index expr rebinding
add test for this scenario

* tryscanindex: fix direct match lookup, range check vec access

* compile on gcc
* via spec: get_schema has a lifetime that is owned by the caller, ergo if the caller wants to drop it, we should let them do that

* oops, still need to check for valid schema!
@peasee peasee self-assigned this Jan 17, 2026
@peasee peasee added the enhancement New feature or request label Jan 17, 2026
@peasee peasee merged commit 58e70bd into spiceai-1.4.3 Jan 18, 2026
101 of 109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants