fix: balance list_contains OR tree for large IN-list filters#37
Merged
phillipleblanc merged 1 commit intoApr 7, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses stack overflows when evaluating list_contains against large constant IN-lists by building the OR-combination of element-wise equality checks as a balanced tree rather than a left-deep chain, and adds regression/structural tests to prevent reintroducing the issue.
Changes:
- Refactor constant-list
list_containsevaluation to build a balanced OR reduction tree (or_arrays_balanced). - Add a regression test for large constant lists (2048 elements) to ensure evaluation completes correctly.
- Add a structural test to validate the resulting OR tree depth is bounded.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sgrebnov
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_containsOR combinations as a balanced tree instead of a left-deep chainTesting