Skip to content

Conversation

@ohitstom
Copy link
Contributor

@ohitstom ohitstom commented Mar 11, 2024

in reference to this description

regex tested on:
image

@Delusoire
Copy link
Contributor

Delusoire commented Mar 11, 2024

This doesn't allow rearranging Meet DJ and Video Courses because they're only added later.
image

@ohitstom
Copy link
Contributor Author

ohitstom commented Mar 11, 2024

This doesn't allow rearranging Meet DJ and Video Courses because they're only added later.
image

edit: good point, have found a regex and tested on all compatible versions

@rxri
Copy link
Member

rxri commented Mar 11, 2024

good shit, i tested it but it seems like the javascript side is broken now. When I click down or up, the whole section goes to bottom or top, it doesn't move one by one basically. Perhaps it's intended behavior? I don't know really, I never used it at all

@ohitstom
Copy link
Contributor Author

ohitstom commented Mar 11, 2024

good shit, i tested it but it seems like the javascript side is broken now. When I click down or up, the whole section goes to bottom or top, it doesn't move one by one basically

unless im misunderstanding i believe thats intended, basically stick puts it right at the top, lower puts it right at the bottom, then up or down will move within either stuck sections or lowered sections - i did however notice that if you make a change, the second you change a page and come back it resets until your reload which it wasnt doing with my graphql approach?

any chance you can attach a vid? :)

sidenote:
Spicetify.Menu.Items no longer work properly, someones removed trailing icons completely so toggling on and off (the check mark) no longer works! any chance this can be fixed, shall i open an issue?

@rxri
Copy link
Member

rxri commented Mar 11, 2024

nvm i'm just stupid and it stays in the same place for me when i change pages

@ohitstom
Copy link
Contributor Author

ohitstom commented Mar 11, 2024

nvm i'm just stupid and it actually stays in the same place for me when i change pages

🎉 will do some testing on why thats not the case for me, might be user error or my localstorage key is messed up

thoughts on the menu item issue?

@rxri
Copy link
Member

rxri commented Mar 11, 2024

thoughts on the menu item issue?

known, we didn't bother troubleshooting it further because it worked before and it broke somewhere idk

@ohitstom
Copy link
Contributor Author

thoughts on the menu item issue?

known, we didn't bother troubleshooting it further because it worked before and it broke somewhere idk

unfortunate, i had a quick look but the new system looks totally different to me haha
i did however fix the logic as its initial state was bugged (in homev2)

@ohitstom ohitstom changed the title fix(homeConfig): support all versions fix(homeConfig): support all versions & fix menuItem states Mar 11, 2024
Copy link
Member

@rxri rxri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make z-index on #spicetify-home-config very high so it's always on top
run go fmt .
run biome plox

@ohitstom
Copy link
Contributor Author

ohitstom commented Mar 11, 2024

make z-index on #spicetify-home-config very high so it's always on top run go fmt . run biome plox

will do

edit:
what is plox?

@ohitstom ohitstom marked this pull request as ready for review March 12, 2024 00:02
@graphite-app graphite-app bot added wrapper Issue or Pull Request about wrapper functionality core Issue or Pull Request about core functionality labels Mar 12, 2024
@graphite-app
Copy link

graphite-app bot commented Mar 12, 2024

Graphite Automations

"Add `wrapper` label on wrapper related changes" took an action on this PR • (03/12/24)

1 label was added to this PR based on ririxi's automation.

"Add `core` label on cli related changes" took an action on this PR • (03/12/24)

1 label was added to this PR based on ririxi's automation.

@rxri
Copy link
Member

rxri commented Mar 12, 2024

make z-index on #spicetify-home-config very high so it's always on top run go fmt . run biome plox

will do

edit: what is plox?

https://www.dictionary.com/e/slang/plox/
menu item checkmark will be fixed by #2899

@ohitstom
Copy link
Contributor Author

ohitstom commented Mar 12, 2024

menu item checkmark will be fixed by #2899

feel free to say no but may i request that icons still stay on the right like the account one?
image
then if item is enabled it replaces the given icon with a check? i feel like that matches Spotify a little bit more !

@rxri
Copy link
Member

rxri commented Mar 12, 2024

The account one is like this because that's common or let's say "standard" to have icon like this on the right to external link, not on the left

@ohitstom
Copy link
Contributor Author

The account one is like this because that's common or let's say "standard" to have icon like this on the right to external link, not on the left

sounds good just my OCD haha :)

@afonsojramos
Copy link
Member

Let's gooooo

@rxri rxri changed the title fix(homeConfig): support all versions & fix menuItem states fix(homeConfig): support all versions Mar 12, 2024
@rxri rxri merged commit c9b6250 into spicetify:master Mar 12, 2024
@ani9730
Copy link

ani9730 commented Mar 13, 2024

Can anyone explain what this home config feature actually does?

@ohitstom
Copy link
Contributor Author

ohitstom commented Mar 13, 2024

Can anyone explain what this home config feature actually does?

allows you to re-order sections in the home page

@ohitstom ohitstom deleted the homeV2 branch March 13, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issue or Pull Request about core functionality wrapper Issue or Pull Request about wrapper functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants