-
-
Notifications
You must be signed in to change notification settings - Fork 829
fix(homeConfig): support all versions #2897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
good shit, i tested it but it seems like the javascript side is broken now. When I click |
unless im misunderstanding i believe thats intended, basically stick puts it right at the top, lower puts it right at the bottom, then up or down will move within either stuck sections or lowered sections - i did however notice that if you make a change, the second you change a page and come back it resets until your reload which it wasnt doing with my graphql approach? any chance you can attach a vid? :) sidenote: |
|
nvm i'm just stupid and it stays in the same place for me when i change pages |
🎉 will do some testing on why thats not the case for me, might be user error or my localstorage key is messed up thoughts on the menu item issue? |
known, we didn't bother troubleshooting it further because it worked before and it broke somewhere idk |
unfortunate, i had a quick look but the new system looks totally different to me haha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make z-index on #spicetify-home-config very high so it's always on top
run go fmt .
run biome plox
will do edit: |
Graphite Automations"Add `wrapper` label on wrapper related changes" took an action on this PR • (03/12/24)1 label was added to this PR based on ririxi's automation. "Add `core` label on cli related changes" took an action on this PR • (03/12/24)1 label was added to this PR based on ririxi's automation. |
https://www.dictionary.com/e/slang/plox/ |
feel free to say no but may i request that icons still stay on the right like the account one? |
|
The account one is like this because that's common or let's say "standard" to have icon like this on the right to external link, not on the left |
sounds good just my OCD haha :) |
|
Let's gooooo |
|
Can anyone explain what this home config feature actually does? |
allows you to re-order sections in the home page |


in reference to this description
regex tested on:
