Skip to content

Conversation

@rxri
Copy link
Member

@rxri rxri commented Apr 10, 2024

This needs testing, please. I tried my best to test it out on both extensions and custom apps and tried all combinations but I feel like I forgot something. What I have tried:

  • extensions
    • spicetify config extensions "trashbin.js|fullAppDisplay.js"
      image
    • spicetify config extensions "trashbin.js|fullAppDisplay.js-"
      image
    • spicetify config extensions "trashbin.js-|fullAppDisplay.js"
      image
      image
    • spicetify config extensions "trashbin.js-|fullAppDisplay.js-" (I did not bother showing multiple values on removal)
      image
      image
    • spicetify config extensions "trashbin.js"
      image
      image
    • spicetify config extensions "trashbin.js-"
      image
      image
  • custom apps
    • spicetify config custom_apps "lyrics-plus|stats"
      image
    • spicetify config custom_apps "lyrics-plus|stats-"
      image
      image
    • spicetify config custom_apps "lyrics-plus-|stats"
      image
      image
    • spicetify config custom_apps "lyrics-plus"
      image
    • spicetify config custom_apps "lyrics-plus-"
      image
      image

edit: no need to test it. I already did that by myself, as shown above.

@graphite-app graphite-app bot added the core Issue or Pull Request about core functionality label Apr 10, 2024
@graphite-app
Copy link

graphite-app bot commented Apr 10, 2024

Graphite Automations

"Add `core` label on cli related changes" took an action on this PR • (04/10/24)

1 label was added to this PR based on ririxi's automation.

"Add `wrapper` label on wrapper related changes" took an action on this PR • (04/15/24)

1 label was added to this PR based on ririxi's automation.

@rxri
Copy link
Member Author

rxri commented Apr 12, 2024

@afonsojramos @theRealPadster 🥱

@graphite-app graphite-app bot added the wrapper Issue or Pull Request about wrapper functionality label Apr 15, 2024
Co-authored-by: Afonso Jorge Ramos <afonsojorgeramos@gmail.com>
@rxri rxri changed the title fix(cmd/config): check for duplicates when adding multiple values fix(config): check for duplicates when adding multiple values Apr 15, 2024
@rxri rxri merged commit 1ba6ef0 into master Apr 15, 2024
@rxri rxri deleted the fix/cmd/config branch April 15, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issue or Pull Request about core functionality wrapper Issue or Pull Request about wrapper functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants