feat(css-map): add more 1.2.86 classes and a few others#3782
feat(css-map): add more 1.2.86 classes and a few others#3782rxri merged 6 commits intospicetify:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
css-map.json (1)
1-2571: Add a CI sanity check for duplicate keys and key typo regressions.Given the file size and frequent bulk updates, a small guard would prevent silent key overwrites and accidental reintroduction of
libaryFilter-style typos.#!/bin/bash set -euo pipefail python - <<'PY' import json from collections import Counter path = "css-map.json" text = open(path, "r", encoding="utf-8").read() # Detect duplicate keys via object_pairs_hook dupes = [] def hook(pairs): c = Counter(k for k, _ in pairs) for k, n in c.items(): if n > 1: dupes.append((k, n)) return dict(pairs) data = json.loads(text, object_pairs_hook=hook) if dupes: print("FAIL: Duplicate keys found:") for k, n in dupes: print(f" {k}: {n} occurrences") raise SystemExit(1) # Assert key typo fix remains correct expected_key = "nGNsefRulpsAkpRc" expected_value = "main-yourLibraryX-libraryFilter" if data.get(expected_key) != expected_value: print(f"FAIL: {expected_key} != {expected_value}") raise SystemExit(1) if any(v == "main-yourLibraryX-libaryFilter" for v in data.values()): print("FAIL: Found deprecated typo value main-yourLibraryX-libaryFilter") raise SystemExit(1) print("PASS: css-map.json sanity checks succeeded.") PY🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@css-map.json` around lines 1 - 2571, Add a CI sanity check that validates css-map.json for duplicate JSON keys, enforces the corrected mapping for key "nGNsefRulpsAkpRc" -> "main-yourLibraryX-libraryFilter", and rejects any value "main-yourLibraryX-libaryFilter"; implement this as a small script (e.g., a bash wrapper that runs an embedded Python check like the provided snippet) and wire it into the project's CI pipeline so the job fails on duplicates or the typo/value regression.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@css-map.json`:
- Around line 1-2571: Add a CI sanity check that validates css-map.json for
duplicate JSON keys, enforces the corrected mapping for key "nGNsefRulpsAkpRc"
-> "main-yourLibraryX-libraryFilter", and rejects any value
"main-yourLibraryX-libaryFilter"; implement this as a small script (e.g., a bash
wrapper that runs an embedded Python check like the provided snippet) and wire
it into the project's CI pipeline so the job fails on duplicates or the
typo/value regression.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: cc02ce40-9b21-4178-a786-4d8ea315a8a1
📒 Files selected for processing (1)
css-map.json
|
@Ingan121 can u run biome on it |
|
Done |
GenericModal__overlayandmain-userWidget-box, which is required forSpicetify.PopupModalandSpicetify.Menu.Itemto work properlyxpui-root-dialogs.cssandxpui-routes-playlist.cssfrom Spotify 1.2.70, 1.2.84/85, and 1.2.86. Some adjacent classes that have been missing since 1.2.72 are also added.TrackCreditsModalV2, which can be toggled in the experimental features in 1.2.70. The toggle has no effect on 1.2.84/1.2.86, and the new credits modal is always enabled.lZCogpVJ9VYr762A) and a map with a typo ("nGNsefRulpsAkpRc": "main-yourLibraryX-libaryFilter")Summary by CodeRabbit