Skip to content

Invalid 7.2 exchange file [AB#1934504]#517

Merged
jasongarrett merged 5 commits intomasterfrom
invalid-7.2-exchange-file-1934504
Mar 2, 2026
Merged

Invalid 7.2 exchange file [AB#1934504]#517
jasongarrett merged 5 commits intomasterfrom
invalid-7.2-exchange-file-1934504

Conversation

@phillipdlai
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds regression coverage and fixture data around v10 down-conversion of load cases, specifically ensuring designs/results don’t retain broken “detailed results” references after removing newer load cases.

Changes:

  • Update LoadCaseChangeSet revert behavior to drop analysisDetails / mark analysisCurrent=false when no summary results remain, and to correctly propagate anyChanged in revertResults.
  • Add new v10 conversion fixtures (LoadCase-*.json) to reproduce/guard the invalid-results scenarios.
  • Extend Spock tests to cover analysisDetails cleanup and schema-validity expectations.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/main/groovy/com/spidasoftware/schema/conversion/changeset/v10/LoadCaseChangeSet.groovy Adjusts revert logic for designs/results after removing certain load cases.
src/test/groovy/com/spidasoftware/schema/conversion/changeset/v10/LoadCaseChangeSetTest.groovy Adds regression tests for design/result revert behavior and schema validation.
src/test/resources/conversions/v10/LoadCase-results.json New results fixture used for schema-validity test after revert.
src/test/resources/conversions/v10/LoadCase-project.json New project fixture for “remove analysisDetails when summary results become empty” scenario.
src/test/resources/conversions/v10/LoadCase-project2.json New project fixture ensuring detailed results aren’t removed when summary results remain.
build.gradle Changes default project version string.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jasongarrett jasongarrett merged commit 3c45ab5 into master Mar 2, 2026
1 check passed
@jasongarrett jasongarrett deleted the invalid-7.2-exchange-file-1934504 branch March 2, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants