Invalid 7.2 exchange file [AB#1934504]#517
Merged
jasongarrett merged 5 commits intomasterfrom Mar 2, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds regression coverage and fixture data around v10 down-conversion of load cases, specifically ensuring designs/results don’t retain broken “detailed results” references after removing newer load cases.
Changes:
- Update
LoadCaseChangeSetrevert behavior to dropanalysisDetails/ markanalysisCurrent=falsewhen no summary results remain, and to correctly propagateanyChangedinrevertResults. - Add new v10 conversion fixtures (
LoadCase-*.json) to reproduce/guard the invalid-results scenarios. - Extend Spock tests to cover
analysisDetailscleanup and schema-validity expectations.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/main/groovy/com/spidasoftware/schema/conversion/changeset/v10/LoadCaseChangeSet.groovy |
Adjusts revert logic for designs/results after removing certain load cases. |
src/test/groovy/com/spidasoftware/schema/conversion/changeset/v10/LoadCaseChangeSetTest.groovy |
Adds regression tests for design/result revert behavior and schema validation. |
src/test/resources/conversions/v10/LoadCase-results.json |
New results fixture used for schema-validity test after revert. |
src/test/resources/conversions/v10/LoadCase-project.json |
New project fixture for “remove analysisDetails when summary results become empty” scenario. |
src/test/resources/conversions/v10/LoadCase-project2.json |
New project fixture ensuring detailed results aren’t removed when summary results remain. |
build.gradle |
Changes default project version string. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… invalid-7.2-exchange-file-1934504
jasongarrett
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.