Avoid netty warning by setting unknown channel option to null#24
Merged
maxlambrecht merged 3 commits intospiffe:devfrom May 18, 2020
Merged
Avoid netty warning by setting unknown channel option to null#24maxlambrecht merged 3 commits intospiffe:devfrom
maxlambrecht merged 3 commits intospiffe:devfrom
Conversation
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
…th linux and mac. Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
prat0318
reviewed
May 18, 2020
| .channelType(EpollDomainSocketChannel.class); | ||
| // avoid Unknown channel option 'SO_KEEPALIVE' | ||
| .withOption(ChannelOption.SO_KEEPALIVE, null) | ||
| .channelType(EpollDomainSocketChannel.class); |
There was a problem hiding this comment.
I patched the diff to my package (it might be a bit older version of the repo though), and i am getting this compile error in IDE:
Required type:
io.grpc.netty.shaded.io.netty.channel.ChannelOption
<T>
Provided:
io.netty.channel.ChannelOption
<Boolean>
reason: no instance(s) of type variable(s) T exist so that ChannelOption<Boolean> conforms to ChannelOption<T>
@maxlambrecht Any idea why?
Member
Author
There was a problem hiding this comment.
what do you get if you run ./gradlew clean build ?
prat0318
approved these changes
May 18, 2020
| .channelType(EpollDomainSocketChannel.class); | ||
| // avoid Unknown channel option 'SO_KEEPALIVE' | ||
| .withOption(ChannelOption.SO_KEEPALIVE, null) | ||
| .channelType(EpollDomainSocketChannel.class); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep-alive option is not set for Unix Domain Socket connections. Setting this option causes warnings in the log and the option has no effect on the channel.
Signed-off-by: Max Lambrecht maxlambrecht@gmail.com