[aws_iid] tolerate network interfaces not being ordered by device index#5300
Merged
amartinezfayo merged 2 commits intospiffe:mainfrom Jul 30, 2024
Merged
Conversation
Manbeardo
requested review from
MarcosDY,
amartinezfayo,
azdagron,
evan2645 and
rturner3
as code owners
Member
amartinezfayo
left a comment
amartinezfayo
left a comment
There was a problem hiding this comment.
Thank you @Manbeardo for this contribution, it looks great.
Just a small comment.
Manbeardo
force-pushed
the
aws-iid-network-interface-order
branch
from
823211e to
5326564
Compare
Signed-off-by: James Ribe <manbeardo@gmail.com>
Manbeardo
force-pushed
the
aws-iid-network-interface-order
branch
from
8902b39 to
b846f7d
Compare
Contributor
Author
|
replaced |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
aws_iidagent NodeAttestorDescription of change
This diff updates the
aws_iidnode attestation process to search the list of network interfaces for the interface with device index 0 instead of bailing out if the first element of the list does not have device index 0.I don't believe this change requires a documentation update. Please point me in the right direction if that's incorrect.
Which issue this PR fixes
#5299