Fix flaky TestHostForwarding by receiving client payload before responding#6756
Merged
amartinezfayo merged 2 commits intoMar 17, 2026
Merged
Conversation
…onding Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
amartinezfayo
requested review from
MarcosDY,
evan2645,
rturner3 and
sorindumitru
as code owners
sorindumitru
approved these changes
Mar 17, 2026
iamP1
added a commit
to iamP1/spire
that referenced
this pull request
Mar 20, 2026
…onding (spiffe#6756) Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> Co-authored-by: Sorin Dumitru <sorin@returnze.ro>Signed-off-by: iamP1 <nhegde@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ForwardedHostV1Plugin used in TestHostForwarding was sending a response and returning without first calling stream.Recv() to consume the client's payload. This created a race condition: if the server closed its side of the stream before the client's stream.Send() completed, the send would return io.EOF, which V1.streamError converts to "plugin closed stream unexpectedly".
An example of a failure in the test can be found here: https://github.com/spiffe/spire/actions/runs/23202195179/job/67427532224#step:5:209
The fix adds a stream.Recv() call in the plugin handler before sending the response, synchronizing the bidirectional stream protocol so the server waits for the client's payload before responding.