Skip to content

Fix flaky upstream-authority-vault and upstream-authority-ejbca integration tests#6836

Merged
amartinezfayo merged 1 commit into
spiffe:mainfrom
amartinezfayo:fix-upstream-authority-vault-integration-test
Apr 7, 2026
Merged

Fix flaky upstream-authority-vault and upstream-authority-ejbca integration tests#6836
amartinezfayo merged 1 commit into
spiffe:mainfrom
amartinezfayo:fix-upstream-authority-vault-integration-test

Conversation

@amartinezfayo
Copy link
Copy Markdown
Member

The upstream-authority-vault and upstream-authority-ejbca integration test suites were intermittently failing with error: no matching resources found when running kubectl wait pods -l app=spire-server --for=condition=Ready.

After kubectl apply, Kubernetes creates the Deployment object first, then the Deployment controller creates the ReplicaSet, which then creates the Pod. If kubectl wait runs before any pods with the label selector exist, it exits with an error immediately. With set -e active in the test scripts, this causes the step to fail.

This PR replaces the four kubectl wait pods ... --for=condition=Ready calls in upstream-authority-vault/02-deploy-spire-and-verify-auth and the one in upstream-authority-ejbca/02-deploy-spire with kubectl rollout status deployment/spire-server, which operates on the Deployment resource directly and correctly handles the window between kubectl apply and pod creation.

Example of failure: https://github.com/spiffe/spire/actions/runs/24039273578/job/70107728628?pr=6833

…ration tests

Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
@amartinezfayo amartinezfayo added this to the 1.15.0 milestone Apr 7, 2026
@amartinezfayo amartinezfayo added this pull request to the merge queue Apr 7, 2026
Merged via the queue into spiffe:main with commit 427664d Apr 7, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants