Specify a read buffer size for agent WorkloadAPI server#6875
Merged
Conversation
gRPC allocates a 32KB buffer per active connection for reading data from callers. This is excessive since we don't usually have large incoming requests. In a testing setup this dropped the memory usage of spire-agent from ~340MB to ~200MB In the case where we have larger incoming payloads, we would end up making multiple read() calls to read the incoming data, so no functionality is affected but if there are larger requests (maybe for the SDSv3 API?) incoming we could have some performance degradation. Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
sorindumitru
requested review from
MarcosDY,
amartinezfayo,
evan2645 and
rturner3
as code owners
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
Hopefully none, but it may lead to multiple read() calls when reading large requests for WorkloadAPI, SDSv3 and gRPC Healthcheck.
Description of change
gRPC allocates a 32KB buffer per active connection for reading data from callers. This is excessive since we don't usually have large incoming requests.
In a testing setup this dropped the memory usage of spire-agent from ~340MB to ~200MB
In the case where we have larger incoming payloads, we would end up making multiple read() calls to read the incoming data, so no functionality is affected but if there are larger requests (maybe for the SDSv3 API?) incoming we could have some performance degradation.