sigstore: promote out of experimental#6901
Merged
amartinezfayo merged 2 commits intoApr 22, 2026
Merged
Conversation
Moves the sigstore block to the top level of the k8s and docker workload
attestor configs. The experimentalK8SConfig and experimentalConfig wrapper
structs are removed, and buildConfig reads from newConfig.Sigstore directly.
Sigstore has stable integration test coverage in test/integration/suites/
k8s-sigstore, so it's ready to be officially supported. The feature stays
optional and only activates when the sigstore block is configured.
Config surface change: existing configs using experimental { sigstore {...} }
must move the sigstore block out of the experimental wrapper.
Fixes spiffe#6900
Signed-off-by: Mateen Anjum <mateenali66@gmail.com>
mateenali66
requested review from
MarcosDY,
amartinezfayo,
evan2645,
rturner3 and
sorindumitru
as code owners
amartinezfayo
approved these changes
Apr 22, 2026
Member
amartinezfayo
left a comment
amartinezfayo
left a comment
There was a problem hiding this comment.
Thank you for this contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moves the sigstore block to the top level of the k8s and docker workload attestor configs. the
experimentalK8SConfigandexperimentalConfigwrapper structs are gone andbuildConfigreads fromnewConfig.Sigstoredirectly.per discussion on the issue, this is a hard cutover with no deprecation window. existing configs using
experimental { sigstore {...} }need to move thesigstoreblock out of the wrapper. sample configs, plugin docs, and the k8s-sigstore integration test suite are updated to match.tested locally with
go test ./pkg/agent/...andmake lint-code.Fixes #6900