fix(downloader): extract only the shim binary from the archive#604
Open
vdice wants to merge 1 commit intospinframework:mainfrom
Open
fix(downloader): extract only the shim binary from the archive#604vdice wants to merge 1 commit intospinframework:mainfrom
vdice wants to merge 1 commit intospinframework:mainfrom
Conversation
Signed-off-by: Vaughn Dice <vdice@akamai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Tested by way of #605, which adds coverage for the wasmtime shim/app, which would otherwise hit the behavior fixed in this PR.
Issue ticket number and link
Closes #601
Checklist before requesting a review