Skip to content

Conversation

@karthik2804
Copy link
Contributor

Split the example into multiple smaller examples.

@karthik2804 karthik2804 requested a review from dicej February 24, 2023 21:44
@karthik2804
Copy link
Contributor Author

I have resolved all the mentioned suggestions above. I will wait until the KV PR is merged to add a KV example and also potentially an example of using external packages.

@karthik2804 karthik2804 requested a review from dicej February 27, 2023 02:46
@karthik2804
Copy link
Contributor Author

The resolved changes and additional examples for KV and external library usage have now been pushed.

@tpmccallum
Copy link

Hi @karthik2804
Not sure if this is intentional (or to do with this specific PR) but I noticed that the outbound request example returns an additional , the environment: environ({}) and the end of the response.

Here is a dog fact: {"fact":"Dogs could participate in doggie blood drives: dogs are able to donate blood to fellow pooches."}, the environment: environ({})%  

@karthik2804 karthik2804 force-pushed the examples/split_examples branch from de1e1de to 7cf0fb4 Compare February 27, 2023 05:00
@karthik2804
Copy link
Contributor Author

@tpmccallum Thanks for catching that, it has been fixed now.

Signed-off-by: karthik Ganeshram <karthik.ganeshram@fermyon.com>
@karthik2804 karthik2804 force-pushed the examples/split_examples branch from 7cf0fb4 to d76761b Compare February 27, 2023 06:21
@karthik2804 karthik2804 merged commit 2a9ba2f into spinframework:main Feb 27, 2023
@karthik2804 karthik2804 deleted the examples/split_examples branch February 27, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants