rearrange repo and add spin-python-cli
#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`spin-python-cli` is a stand-alone binary for converting a Python app to a Spin-compatible Wasm module. The intention is that we'll publish this as a `Spin` plugin, analogous to the JS/TS SDK's `js2wasm` utility. The implementation is a bit more complicated than `js2wasm` because the Python interpreter loads the core library, the app, and its dependencies from disk, so we have to: - Embed the core library in the binary and extract it to a temporary directory prior to pre-initializing with Wizer - Search for the `pipenv` `site-packages` directory and add it to `PYTHONPATH` - Set various environment variables so the Python interpreter knows where to find things (and not buffer stdio) - Set another environment variable so the pre-init function knows which module the app lives in Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
radu-matei
approved these changes
Feb 3, 2023
Member
radu-matei
left a comment
radu-matei
left a comment
There was a problem hiding this comment.
Built from source and tested the sample application included here, everything seems to work great!
One question I have is around type hints, and whether that is something we would like to include.
LGTM!
Collaborator
Author
|
By "type hints", I assume you mean Anyway, yes, that would be cool to add. |
|
Type hints are baked into the stdlib/language now. See the |
karthik2804
approved these changes
Feb 3, 2023
Contributor
karthik2804
left a comment
karthik2804
left a comment
There was a problem hiding this comment.
This is looking great!
dicej
pushed a commit
that referenced
this pull request
Jan 26, 2024
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spin-python-cliis a stand-alone binary for converting a Python app to a Spin-compatible Wasm module. The intention is that we'll publish this as aSpinplugin, analogous to the JS/TS SDK'sjs2wasmutility.The implementation is a bit more complicated than
js2wasmbecause the Python interpreter loads the core library, the app, and its dependencies from disk, so we have to:pipenvsite-packagesdirectory and add it toPYTHONPATHSigned-off-by: Joel Dice joel.dice@fermyon.com