docs(examples): add suggested postgres setup #52
Conversation
examples/postgres-v3/README.md
Outdated
| Then, run the following from the root of this example: | ||
|
|
||
| ``` | ||
| export PGUSER=postgres PGHOST=localhost |
There was a problem hiding this comment.
When I did this I was running createdb and psql inside the container. I guess that isn't needed?
How would you feel about putting these as arguments on the commands (-h / -U) instead of environment variables? Just thinking about Unix/Windows portability here. I don't have a strong feeling about it, just flagging it for consideration. (And I guess since we use RUST_LOG= on the build line it's moot really.)
There was a problem hiding this comment.
👍 Always appreciate vigilance on OS-portability! Updated.
examples/postgres/README.md
Outdated
| export PGUSER=postgres PGHOST=localhost | ||
| createdb spin_dev | ||
| psql -d spin_dev -f db/testdata.sql | ||
| RUST_LOG=spin=trace spin build --up |
There was a problem hiding this comment.
Consider removing the RUST_LOG while we're in here? It seems like it's only likely to clutter the output? (I realise it's a separate change of course. Not a must-do if you want to keep the PR focused.)
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
vdice
force-pushed
the
docs/postgres-example-readmes
branch
from
24aab25 to
60b4cfb
Compare
2 participants
Ref #49 (comment)
Closes #49