Add cron character explanation and give examples of different schedules #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tpmccallum tim.mccallum@fermyon.com Signed-off-by: Timothy McCallum <tim.mccallum@fermyon.com>
tpmccallum
commented
May 16, 2024
Signed-off-by: tpmccallum tim.mccallum@fermyon.com Signed-off-by: Timothy McCallum <tim.mccallum@fermyon.com>
itowlson
approved these changes
May 16, 2024
Contributor
itowlson
left a comment
itowlson
left a comment
There was a problem hiding this comment.
Some nits but otherwise LGTM
README.md
Outdated
| The `cron_expression` format for scheduling is as follows: | ||
|
|
||
| ```text | ||
| sec min hour day of month month day of week year |
Contributor
There was a problem hiding this comment.
This isn't actually part of the expression is it?
Author
There was a problem hiding this comment.
Ah, yes. I have updated so that we refer to the sec, min etc. as fields. I also use a bit of ascii-art inspired text to show each of the fields.
Signed-off-by: tpmccallum tim.mccallum@fermyon.com Co-authored-by: itowlson <ivan.towlson@fermyon.com> Signed-off-by: Timothy McCallum <tim.mccallum@fermyon.com>
Signed-off-by: tpmccallum tim.mccallum@fermyon.com Co-authored-by: itowlson <ivan.towlson@fermyon.com> Signed-off-by: Timothy McCallum <tim.mccallum@fermyon.com>
Signed-off-by: tpmccallum tim.mccallum@fermyon.com Co-authored-by: itowlson <ivan.towlson@fermyon.com> Signed-off-by: Timothy McCallum <tim.mccallum@fermyon.com>
Signed-off-by: tpmccallum tim.mccallum@fermyon.com Signed-off-by: Timothy McCallum <tim.mccallum@fermyon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tpmccallum tim.mccallum@fermyon.com