Vendor openssl
#30
Merged
Vendor openssl
#30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
karthik2804
approved these changes
Apr 10, 2025
|
Had to bypass branch protection because adding the feature changed the check name so of course BP needed to be changed to match. That is done now - hopefully future PRs will line up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the Spin build now sets
--features openssl/vendoredon Ubuntu AMD64 builds, because apparently Ubuntu 22 no longer ships libssl1.1 and apparently this causes woe (https://github.com/spinframework/spin/blob/main/.github/workflows/release.yml#L32). I dunno if it causes the same woe but a user who was trying a canary ran into a libssl issue and well maybe better safe than sorry. Definitely feel free to close if it's not needed!