Non-maintainers can't merge their own approved PRs

[calebschoepp]

With the recent governance change non-maintainers have lost the ability to merge their own PRs that have been approved. I've found this to be unergonomic because now I have to revert to pinging people in comments to get them to merge my PR.

[michelleN]

@calebschoepp would enabling auto-merge for approved PRs resolve this issue?

[lann]

fwiw I don't trust auto-merge right now. I just had it merge a PR that ultimately failed CI... 😬

[calebschoepp]

Who enables auto-merge? Me the non-maintainer or a maintainer who approved the PR?

[itowlson]

@lann We added some checks to the workflow to improve parity with main CI, but they are not 'required' (because they were added after the 'required' stuff got set up). So yeah auto-merge will pull the trigger once the original subset of checks passes, and not wait for the full checks. If you're an admin, you might be able to make the newer checks 'required' - I didn't have permissions.

</derailing>

[rylev]

FYI: we were previously missing some "required" checks on certain CI jobs that should have blocked auto-merge on failure but did not. I updated these early this week to block on failure so we should be good to use auto-merging IMO.

[michelleN]

To your question @calebschoepp about the auto-merge process: now that all the checks are in place, I think the maintainer should hit "enable automerge" once they have lgtm'ed the PR.

[calebschoepp]

This seems like a reasonable conclusion for this ticket.

[michelleN]

Let's document this as a maintainer responsibility in CONTRIBUTING.md