Include body sizes in outbound HTTP telemetry

[lann]

This would be useful for egress bandwidth accounting. See e.g. https://opentelemetry.io/docs/specs/semconv/registry/attributes/http/#http-request-body-size

The easy version of this would be to just report body sizes based off of content-length headers, which would work for "most" requests. The harder but more complete version would be to use custom Body wrapper(s) to record the actual bytes written, which would additionally work for streaming/chunked-encoding bodies that have no content-length.

[lann]

I just realized that the current span only accounts for the time between when the request is sent and when the response header is received. Any additional time spent receiving the body isn't accounted for. A custom response body wrapper would also allow us to rectify that.

[ChihweiLHBird]

I am interested in working on this. Is it the work still needed?

[lann]

Yes, still needed. Thanks!

Adding a bit of detail:

The easier version of this would be to add the standard fields http.request.header.content-length and http.response.header.content-length (if the headers are present) to the span here.

The more difficult (but more complete) version of this would be to implement http.request.body.size/http.response.body.size which requires a wrapping http_body::Body to count bytes. This would be relatively straightforward for responses where there already is a wrapper.

So really I think there are 3 options of significantly increasing difficulty:

1. http.{request,response}.header.content-length
2. http.request.header.content-length and http.response.body.size (based on the existing wrapper)
3. http.{request,response}.body.size