add ServiceIndices field to HandlerType::Wasi0_3#3449
Merged
dicej merged 1 commit intospinframework:mainfrom Apr 9, 2026
Merged
add ServiceIndices field to HandlerType::Wasi0_3#3449dicej merged 1 commit intospinframework:mainfrom
ServiceIndices field to HandlerType::Wasi0_3#3449dicej merged 1 commit intospinframework:mainfrom
Conversation
itowlson
approved these changes
Apr 8, 2026
dicej
force-pushed
the
store-indices-in-handlertype-wasi03
branch
from
d563a62 to
5d3ad1f
Compare
This allows embedders to efficiently invoke WASIp3 handlers _without_ using `wasmtime_wasi_http::handler`'s instance reuse machinery if desired. Technically, that could be accomplished without this patch by calling `ProxyHandler::instance_pre` and converting that to a `ServiceIndices` object, but that's expensive to do on each request, so it's better to do it once during setup.
dicej
force-pushed
the
store-indices-in-handlertype-wasi03
branch
from
5d3ad1f to
c130c01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows embedders to efficiently invoke WASIp3 handlers without using
wasmtime_wasi_http::handler's instance reuse machinery if desired. Technically, that could be accomplished without this patch by callingProxyHandler::instance_preand converting that to aServiceIndicesobject, but that's expensive to do on each request, so it's better to do it once during setup.