Skip to content

Add http-rust-p2 compatibility template#3486

Merged
fibonacci1729 merged 3 commits into
mainfrom
http-rust-p2
Apr 28, 2026
Merged

Add http-rust-p2 compatibility template#3486
fibonacci1729 merged 3 commits into
mainfrom
http-rust-p2

Conversation

@fibonacci1729
Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
Comment thread templates/http-rust-p2/metadata/spin-template.toml Outdated
Copy link
Copy Markdown
Collaborator

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The content LGTM but I had a non-blocking suggestion on the description.

@itowlson
Copy link
Copy Markdown
Collaborator

Oh you will need to update TPLS_IN_THIS in the templates crate unit tests (it asserts that the right number of things have been installed and so numbers need to line up)

Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
@fibonacci1729 fibonacci1729 enabled auto-merge (squash) April 27, 2026 22:16
Comment thread templates/http-rust-p2/metadata/spin-template.toml Outdated
@fibonacci1729 fibonacci1729 disabled auto-merge April 28, 2026 00:40
Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
@fibonacci1729 fibonacci1729 enabled auto-merge (squash) April 28, 2026 01:53
@fibonacci1729 fibonacci1729 merged commit 061666c into main Apr 28, 2026
32 of 33 checks passed
@fibonacci1729 fibonacci1729 deleted the http-rust-p2 branch April 28, 2026 17:36
fibonacci1729 added a commit that referenced this pull request May 20, 2026
* Add http-rust-p2 compatibility template

Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>

* Update TPLS_IN_THIS and template description

Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>

* template id

Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>

---------

Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
(cherry picked from commit 061666c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants