spin new -E and spin plugins -E#3509
Merged
Merged
Conversation
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Collaborator
Author
|
Sorry I thought I had clippied this. I have stuff going on which mean I have uncommitted stuff in my working copy, so I will fix the lints in the morning along with those. |
292ad58 to
a389625
Compare
a389625 to
f2b1b72
Compare
Collaborator
Author
|
For my testing I have used https://raw.githubusercontent.com/itowlson/spin/4f12a8b60dd5d66ed79df89e50fddf00f18519c3/target-envs/env-mc-envface.toml (note this is removed from the PR so you will need to address it at that specific commit). |
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
f2b1b72 to
f36d746
Compare
fibonacci1729
approved these changes
May 14, 2026
Collaborator
fibonacci1729
left a comment
There was a problem hiding this comment.
Thanks for this! Works great for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3494
This adds:
spin new -E- looks for the template in the repo pointed to by the given environmentspin plugins install -E- install the plugins suggested in the given environment, or the environment for the current app if-Ewith no env namespin plugins list -E- list the plugins suggested in the given environment (again default to current app)Testing things I have to remove:
The fake local env fileDoneInterpreting theNow defaults to catalogue ref. Use-Eas a file ref instead of a catalogue refhttps:prefix to interpret as URL,file:prefix for file pathNeed:
A way for env authors to test against a local file or a GH fork-E file:foo.toml/-E https://example.com/foo.tomlA way to view and install the env plugins if you don't want to do so atDone, at least I think it's done, my brain is friedspin newtimeDefine--accept-defaultsbehaviour when plugins are in play--accept-defaultswill NOT suppress the plugin install prompt