Fix IPv6 allowed outbound host parsing#3579
Merged
Merged
Conversation
e99758f to
7eaccde
Compare
rylev
reviewed
Jun 18, 2026
bb57b3d to
ca9aebf
Compare
rylev
reviewed
Jun 23, 2026
ca9aebf to
05f3f5f
Compare
… and CIDR without explicit ports Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
05f3f5f to
f674bfe
Compare
rylev
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix parsing of
allowed_outbound_hostsentries containing IPv6 literals or IPv6 CIDR ranges without an explicit port.Previously,
rsplit_once(':')could mistake an IPv6 address segment for a port. These entries now use the scheme’s default port:http://[::1]https://[::1]http://ff00::/8The updated parsing also:
http://example.com:/, accepted.Added regression coverage for IPv6 parsing and matching, malformed authorities, wildcard domains, paths, and error messages.