This repository was archived by the owner on Dec 20, 2025. It is now read-only.
fix(docker): Fix subscription leak in DockerTriggerTemplate#6874
Merged
anotherchrisberry merged 1 commit intospinnaker:masterfrom Apr 23, 2019
Merged
Conversation
This subscription leak causes duplicate requests to "/images/tags" endpoint.
Contributor
|
Nice catch, thanks for the fix! |
anotherchrisberry
added a commit
that referenced
this pull request
Apr 23, 2019
* chore(core): Bump version to 0.0.354 96dcf58 refactor(stages): FormikStageConfig to provide Formik for StageConfigs (#6871) bd94593 feat(kubernetes): remove rollout strategies feature flag 2056b64 fix(kubernetes): handle k8s-specific account/region task keys in tasks history view (#6869) * chore(docker): Bump version to 0.0.37 33309a4 fix(docker): Fix subscription leak in DockerTriggerTemplate (#6874)
Contributor
Author
|
Thank you for the quick review and merge! One question, are you going to merge (backport) this change into the previous versions? (1.13 and 1.12) |
Contributor
|
I'll defer to @maggieneterval on backporting this... |
Contributor
Author
|
Cool 👍 |
Contributor
|
Hey @dragon3 good catch, we can definitely patch this into 1.12 and 1.13! |
Contributor
|
@spinnakerbot cherry-pick 1.12 |
Contributor
|
@spinnakerbot cherry-pick 1.13 |
spinnakerbot
pushed a commit
that referenced
this pull request
Apr 24, 2019
This subscription leak causes duplicate requests to "/images/tags" endpoint.
Contributor
|
Cherry pick successful: #6887 |
spinnakerbot
pushed a commit
that referenced
this pull request
Apr 24, 2019
This subscription leak causes duplicate requests to "/images/tags" endpoint.
Contributor
|
Cherry pick successful: #6888 |
maggieneterval
pushed a commit
that referenced
this pull request
Apr 24, 2019
This subscription leak causes duplicate requests to "/images/tags" endpoint.
maggieneterval
pushed a commit
that referenced
this pull request
Apr 24, 2019
This subscription leak causes duplicate requests to "/images/tags" endpoint.
Contributor
Author
|
Nice 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
This pull request changes
initializefunction and addedcomponentWillUnmountfunction to make sure the subscription unsubscribed properly.WHY
I found an issue that
Manual Executionmodal sent duplicate HTTP request to "/images/tags" endpoint.For example, if you click
Start Manual Executionbutton, select a pipeline, 1 OPTION method and 1 GET method request, it's fine:But if you select another pipeline, 2 same GET requests will be sent... :
And if you repeat select pipelines, the number of duplicate HTTP requests will be increased...
It seems that is caused by
subscriptionleak inDockerTriggerTemplate.This pull request is for fixing it.