This repository was archived by the owner on Dec 20, 2025. It is now read-only.
fix(core): use relative imports for ReactSelectInput#6909
Merged
anotherchrisberry merged 1 commit intospinnaker:masterfrom Apr 29, 2019
anotherchrisberry:lib-imports
Merged
fix(core): use relative imports for ReactSelectInput#6909anotherchrisberry merged 1 commit intospinnaker:masterfrom anotherchrisberry:lib-imports
anotherchrisberry merged 1 commit intospinnaker:masterfrom
anotherchrisberry:lib-imports
Conversation
Contributor
Author
|
Finally, some code I am proud of |
anotherchrisberry
added a commit
that referenced
this pull request
Apr 29, 2019
…87 (#6910) * chore(core): Bump version to 0.0.356 bd7bcce fix(core): use relative imports for ReactSelectInput (#6909) e44f22b fix(core): update stage failure component when JSON changes (#6889) 9454e34 fix(core): filter pipeline param choices by search text (#6903) 960048f fix(core): Restore config button on exec view and dropdown for mptv2 (#6894) af5ba5b feat(cf): Create service key SpEL expression (#6828) 62c2b51 feat(cf): Reduce angular dependencies (#6893) 7fde1fa fix(core): Show all app selections when creating a pipeline from mptv2 (#6891) 90fb96c feat(core): UI for configuring pipelines from mptv2 (#6880) fee4c12 fix(core): do not overdo showing the auth modal (#6882) 9c8f12e fix(core): initialize default artifact with type (#6885) 1ced961 refactor(stages): Wire up Pipeline validation to stage validateFn (#6881) * chore(docker): Bump version to 0.0.38 2bd7df1 chore(*): Remove YOLO (#6900) * chore(amazon): Bump version to 0.0.187 151aa2d feat(aws): show ALB listener redirect info in details (#6904)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried three or four different libraries that are supposed to transform
.d.tsfile imports from path aliases to relative paths, but couldn't get any of them to work. Maybe because of our weird "node modules at the top, tsconfig and webpack config at the bottom" setup? I don't know, but I gave up and felt sad about it.