This repository was archived by the owner on Dec 20, 2025. It is now read-only.
fix(runJob/kubernetes): reliably display logs (#7060)#7061
Merged
maggieneterval merged 1 commit intorelease-1.14.xfrom May 24, 2019
Merged
Conversation
* fix(runJob/kubernetes): fix log display fix a case where the log link was being displayed before all the data needed to render it was available. this caused some confusing cases where the link would be rendered but users would be met with a Not Found error in the popup. ultimately this was due to a missing namespace. resolved by pulling the namespace off of the job status instead of depending on the manifest subscription. * fix(runJob/kubernetes): fetch manifest once jobs collect owned pods when collecting job status so we are no longer dependent on subscribing to manifest events to get the pod names created by the job. instead, simply fetch the manifest once. this is more reliable than subscribing to manifest updates.
maggieneterval
deleted the
auto-cherry-pick-1.14-89e4e78505ed8760214389eea683ad929c7a5a9f
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix a case where the log link was being displayed before all the data
needed to render it was available. this caused some confusing cases
where the link would be rendered but users would be met with a Not Found
error in the popup. ultimately this was due to a missing namespace.
resolved by pulling the namespace off of the job status instead of
depending on the manifest subscription.
jobs collect owned pods when collecting job status so we are no longer
dependent on subscribing to manifest events to get the pod names created
by the job. instead, simply fetch the manifest once. this is more
reliable than subscribing to manifest updates.