Skip to content

fix(proto): Fix broken regen-proto script#22

Merged
ttomsu merged 2 commits intospinnaker:masterfrom
ttomsu:proto
Mar 10, 2020
Merged

fix(proto): Fix broken regen-proto script#22
ttomsu merged 2 commits intospinnaker:masterfrom
ttomsu:proto

Conversation

@ttomsu
Copy link
Copy Markdown
Member

@ttomsu ttomsu commented Mar 10, 2020

The only change I made was removing the -u in the regen-protos.sh script.

Here is the error it was generating:

build github.com/mitchellh/protoc-gen-go-json: cannot load github.com/grpc-ecosystem/grpc-gateway/codegenerator: module github.com/grpc-ecosystem/grpc-gateway@latest (v1.14.2) found, but does not contain package github.com/grpc-ecosystem/grpc-gateway/codegenerator

This looks to be an error introduced by a transitive dependency.

From the docs:

The -u flag instructs get to update modules providing dependencies
of packages named on the command line to use newer minor or patch
releases when available. 

With the -u flag, it was upgrading grpc-gateway (a transitive dependency) to v1.14 (a minor version bump) that apparently removed a required package, and thus was actually a breaking change. Sigh...semver is hard.

@ttomsu ttomsu requested review from duftler and plumpy March 10, 2020 13:40
@ttomsu ttomsu merged commit e0d0890 into spinnaker:master Mar 10, 2020
@ttomsu ttomsu deleted the proto branch March 10, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants