Skip to content

breaks when records separated by 2 newlines #1

@bahamas10

Description

@bahamas10

Hey, first of all this is an awesome tool! the linear interpolation is a huge win for me.

The one thing i've noticed however, is it will take a valid .srt over stdin, but spit out the records separated by 2 newlines instead of 1. Then, when I attempt to repipe in the srt file i'm met with.

/opt/local/lib/node_modules/subsync/subsync.js:17
    var elems = str.replace(',','.').split(':').map(parseFloat);
                    ^
TypeError: Cannot call method 'replace' of undefined
    at parseTime (/opt/local/lib/node_modules/subsync/subsync.js:17:21)
    at /opt/local/lib/node_modules/subsync/subsync.js:68:24
    at Array.forEach (native)
    at ReadStream.<anonymous> (/opt/local/lib/node_modules/subsync/subsync.js:63:11)
    at ReadStream.EventEmitter.emit (events.js:117:20)
    at _stream_readable.js:910:16
    at process._tickCallback (node.js:415:13)

When it stringifies the srt back to stdout, it should just skip appending the trailing newline to each record, as it fails to parse it on the way back in.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions