[spiral/router] Update Route list command for customization route class#1070
Merged
butschster merged 2 commits intospiral:masterfrom Jan 26, 2024
Merged
[spiral/router] Update Route list command for customization route class#1070butschster merged 2 commits intospiral:masterfrom
butschster merged 2 commits intospiral:masterfrom
Conversation
Changing the use of an implementation to an interface to implement a custom route
butschster
approved these changes
Jan 24, 2024
Add interface into use block Remove route implementation from use block
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1070 +/- ##
============================================
- Coverage 89.51% 89.50% -0.01%
Complexity 6316 6316
============================================
Files 824 824
Lines 17799 17799
============================================
- Hits 15932 15931 -1
- Misses 1867 1868 +1 ☔ View full report in Codecov by Sentry. |
roxblnfk
approved these changes
Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the use of an implementation to an interface to implement a custom route
I have my own custom route class that inherits from RouteInterface just like the original class from the spiral/router package. However, the command to display routes does not work because it uses an implementation class rather than an interface in the types.
This PR is acknowledged to correct this.