Skip to content

[spiral/router] Update Route list command for customization route class#1070

Merged
butschster merged 2 commits intospiral:masterfrom
S1lentAvenger:feature/route
Jan 26, 2024
Merged

[spiral/router] Update Route list command for customization route class#1070
butschster merged 2 commits intospiral:masterfrom
S1lentAvenger:feature/route

Conversation

@S1lentAvenger
Copy link
Copy Markdown
Contributor

Changing the use of an implementation to an interface to implement a custom route

Q A
Bugfix?
Breaks BC? ✔️
New feature?

I have my own custom route class that inherits from RouteInterface just like the original class from the spiral/router package. However, the command to display routes does not work because it uses an implementation class rather than an interface in the types.
This PR is acknowledged to correct this.

Changing the use of an implementation to an interface to implement a custom route
Add interface into use block
Remove route implementation from use block
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3db2bb2) 89.51% compared to head (295620c) 89.50%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1070      +/-   ##
============================================
- Coverage     89.51%   89.50%   -0.01%     
  Complexity     6316     6316              
============================================
  Files           824      824              
  Lines         17799    17799              
============================================
- Hits          15932    15931       -1     
- Misses         1867     1868       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@butschster butschster merged commit 2c780fc into spiral:master Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants